thomas.heller
2008-11-26 18:40:58 UTC
Author: thomas.heller
Date: Wed Nov 26 19:40:58 2008
New Revision: 67402
Log:
Remove the Py_TPFLAGS_HAVE_GC from the _ctypes.COMError type.
Fixes issue #4433; reviewed by Benjamin Peterson.
Modified:
python/branches/py3k/Misc/NEWS
python/branches/py3k/Modules/_ctypes/_ctypes.c
Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS (original)
+++ python/branches/py3k/Misc/NEWS Wed Nov 26 19:40:58 2008
@@ -24,6 +24,9 @@
Library
-------
+- Issue #4433: Fixed an access violation when garbage collecting
+ _ctypes.COMError instances.
+
- Issue #4429: Fixed UnicodeDecodeError in ctypes.
- Issue #4373: Corrected a potential reference leak in the pickle module and
Modified: python/branches/py3k/Modules/_ctypes/_ctypes.c
==============================================================================
--- python/branches/py3k/Modules/_ctypes/_ctypes.c (original)
+++ python/branches/py3k/Modules/_ctypes/_ctypes.c Wed Nov 26 19:40:58 2008
@@ -5097,8 +5097,7 @@
0, /* tp_getattro */
0, /* tp_setattro */
0, /* tp_as_buffer */
- Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE
- | Py_TPFLAGS_HAVE_GC, /* tp_flags */
+ Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE, /* tp_flags */
PyDoc_STR(comerror_doc), /* tp_doc */
0, /* tp_traverse */
0, /* tp_clear */
Date: Wed Nov 26 19:40:58 2008
New Revision: 67402
Log:
Remove the Py_TPFLAGS_HAVE_GC from the _ctypes.COMError type.
Fixes issue #4433; reviewed by Benjamin Peterson.
Modified:
python/branches/py3k/Misc/NEWS
python/branches/py3k/Modules/_ctypes/_ctypes.c
Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS (original)
+++ python/branches/py3k/Misc/NEWS Wed Nov 26 19:40:58 2008
@@ -24,6 +24,9 @@
Library
-------
+- Issue #4433: Fixed an access violation when garbage collecting
+ _ctypes.COMError instances.
+
- Issue #4429: Fixed UnicodeDecodeError in ctypes.
- Issue #4373: Corrected a potential reference leak in the pickle module and
Modified: python/branches/py3k/Modules/_ctypes/_ctypes.c
==============================================================================
--- python/branches/py3k/Modules/_ctypes/_ctypes.c (original)
+++ python/branches/py3k/Modules/_ctypes/_ctypes.c Wed Nov 26 19:40:58 2008
@@ -5097,8 +5097,7 @@
0, /* tp_getattro */
0, /* tp_setattro */
0, /* tp_as_buffer */
- Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE
- | Py_TPFLAGS_HAVE_GC, /* tp_flags */
+ Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE, /* tp_flags */
PyDoc_STR(comerror_doc), /* tp_doc */
0, /* tp_traverse */
0, /* tp_clear */